Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[raz] Improve RazGSConnection class for better code readability #3617

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

Harshg999
Copy link
Collaborator

@Harshg999 Harshg999 commented Feb 1, 2024

What changes were proposed in this pull request?

  • Consolidating both RazGSConnection and SignedUrlGSConnection into one for better readability and improving docstrings.

How was this patch tested?

  • Manual testing in live setup.

@Harshg999 Harshg999 self-assigned this Feb 1, 2024
@Harshg999 Harshg999 changed the title [DO_NOT_MERGE][raz] Improve RazGSConnection class for better code readability [raz] Improve RazGSConnection class for better code readability Feb 5, 2024
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Harshg999 Harshg999 enabled auto-merge (squash) February 6, 2024 11:48
@Harshg999 Harshg999 merged commit 18c9d8c into master Feb 6, 2024
4 checks passed
@Harshg999 Harshg999 deleted the refactor-gsconnection branch February 6, 2024 11:59
athithyaaselvam pushed a commit that referenced this pull request Feb 14, 2024
- Consolidating both RazGSConnection and SignedUrlGSConnection into one for better readability and improving docstrings.
athithyaaselvam pushed a commit that referenced this pull request Mar 14, 2024
- Consolidating both RazGSConnection and SignedUrlGSConnection into one for better readability and improving docstrings.

(cherry picked from commit 18c9d8c)
(cherry picked from commit 5a7e095daeb3259d786df9cb5feb8dfd70e1676b)
Change-Id: I43fa460516e34bd369eecaced86ce5ac6cd6a220
(cherry picked from commit 90c4c0622b3cab623a934da70bf65d8680b4f542)
athithyaaselvam pushed a commit that referenced this pull request Jun 10, 2024
…bility (#3617)

- Consolidating both RazGSConnection and SignedUrlGSConnection into one for better readability and improving docstrings.

(cherry picked from commit 18c9d8c)
(cherry picked from commit 5a7e095daeb3259d786df9cb5feb8dfd70e1676b)
Change-Id: I43fa460516e34bd369eecaced86ce5ac6cd6a220
(cherry picked from commit ec8e94298759b7de5608f424500bfe59e3dee09f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants