Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] increase muffet buffer size for dead link testing of docs #3627

Merged

Conversation

bjornalm
Copy link
Collaborator

@bjornalm bjornalm commented Feb 21, 2024

What changes were proposed in this pull request?

Fix the failing Github commitflow for documentation lint. For several new PRs it failed with error:
"..small read buffer. Increase ReadBufferSize."

Solution here is to double muffet buffer size to around 8 KB

How was this patch tested?

  • If the commitflow "run documentation lints" passes it should be ok

Please review Hue Contributing Guide before opening a pull request.

Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Harshg999 Harshg999 merged commit 66699eb into master Feb 21, 2024
4 checks passed
@Harshg999 Harshg999 deleted the bjorn--github-commitflow-fails-for-documentation-lint branch February 21, 2024 14:46
athithyaaselvam pushed a commit that referenced this pull request Mar 14, 2024
(cherry picked from commit 66699eb)
(cherry picked from commit 9ff29fa1648c9f8a1278de9fa0d14f444f68212a)
Change-Id: I143d565e0df36a9aec4b5c4cff7c7fc9ba29d9f1
(cherry picked from commit d947338d0fe161c9777580f2e92aa788da6074d9)
athithyaaselvam pushed a commit that referenced this pull request Mar 14, 2024
#3627)"

This reverts commit d947338d0fe161c9777580f2e92aa788da6074d9.

Change-Id: I518acf3b7b3562cb3aa43c4cf36573cfab64f83a
(cherry picked from commit 578b9adb1e3bb0dcfca4ccb269386099c4e57981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants