Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trino] Refactor Trino-related code for readability and maintainability #3637

Merged
merged 2 commits into from
Mar 2, 2024
Merged

[Trino] Refactor Trino-related code for readability and maintainability #3637

merged 2 commits into from
Mar 2, 2024

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Feb 28, 2024

What changes were proposed in this pull request?

  • Refactor Trino code

How was this patch tested?

  • Locally

Harshg999
Harshg999 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

athithyaaselvam
athithyaaselvam approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@athithyaaselvam athithyaaselvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agl29 agl29 enabled auto-merge (squash) March 2, 2024 05:14
@agl29 agl29 merged commit a17d499 into master Mar 2, 2024
3 of 4 checks passed
@agl29 agl29 deleted the improve_trino_code branch March 2, 2024 05:28
athithyaaselvam pushed a commit that referenced this pull request Jun 10, 2024
@agl29
CDPD-67381: [Trino] Refactor Trino-related code for readability and m…
2187aca 
…aintainability (#3637)

(cherry picked from commit a17d499)
(cherry picked from commit 7dfbee799d69967f0f1e6596211dd933fc880335)
Change-Id: I0b9ad9d4fcbe60e77807627a81a5e26c09651d33
(cherry picked from commit db393ad8958178355ec11681722ff46367db57bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athithyaaselvam athithyaaselvam athithyaaselvam approved these changes

@Harshg999 Harshg999 Harshg999 approved these changes

@wing2fly wing2fly Awaiting requested review from wing2fly

@amitsrivastava amitsrivastava Awaiting requested review from amitsrivastava

@JohanAhlen JohanAhlen Awaiting requested review from JohanAhlen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agl29 @athithyaaselvam @Harshg999