[ui-storagebrowser] view file content as text #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramprasadagarwal
requested review from
nidhibhatg,
bjornalm,
tabraiz12 and
ananya-agarwal
nidhibhatg
reviewed
Aug 20, 2024
desktop/core/src/desktop/js/reactComponents/FileChooser/types.ts
Outdated
Show resolved
Hide resolved
## What changes were proposed in this pull request? - There was no API for getting trash path per user. - Earlier, we were depending on a redirect from backend to the trash path but now having a dedicated API for trash path makes sense for revamping the filebrowser UX. - This API is mainly for HDFS for now because other supported filesystems dont have a clear trash use-case concept in Hue. ## How was this patch tested? - Manually
* [ui-core]: feat: add useFetch hook for API calls * add the license information * fix lint * lint fix * add library * pin the library version * revert extra changes * revert package-lock json * fix: rename hook * fix the function name * typecaste error object
bjornalm
requested changes
Aug 21, 2024
...esktop/js/apps/storageBrowser/StorageBrowserPage/StorageBrowserTable/StorageBrowserTable.tsx
Show resolved
Hide resolved
...esktop/js/apps/storageBrowser/StorageBrowserPage/StorageBrowserTable/StorageBrowserTable.tsx
Show resolved
Hide resolved
...esktop/js/apps/storageBrowser/StorageBrowserPage/StorageBrowserTable/StorageBrowserTable.tsx
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/storageBrowser/StorageFilePage/StorageFilePage.scss
Show resolved
Hide resolved
...ps/storageBrowser/StorageBrowserPage/StorageBrowserTabContents/StorageBrowserTabContent.scss
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/storageBrowser/StorageFilePage/StorageFilePage.tsx
Show resolved
Hide resolved
| {fileMetaData.map((row, index) => ( | ||
| <div key={'meta-data-group' + index} className="group"> | ||
| {row.map(item => ( | ||
| <div key={item.name} className="column" data-testid="meta-data-attribute"> |
There was a problem hiding this comment.
data-testid should uniquely identify an element, here there will be multiple with meta-data-attribute, and it is a bit too generic as well. Don't be afraid to create longer ids see https://github.com/cloudera/hue/blob/master/contributing-frontend.md#adding-data-testid-attribute
There was a problem hiding this comment.
It doesn't look like this was resolved
There was a problem hiding this comment.
In the final code, I have removed data-testid as it's not required anymore.
desktop/core/src/desktop/js/apps/storageBrowser/StorageFilePage/StorageFilePage.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/storageBrowser/StorageFilePage/StorageFilePage.tsx
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/storageBrowser/StorageFilePage/StorageFilePage.test.tsx
Outdated
Show resolved
Hide resolved
bjornalm
reviewed
Sep 17, 2024
bjornalm
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
Screenshots
Please review Hue Contributing Guide before opening a pull request.