[Trino] Show query ID in logs for the Trino editor #3857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agl29
requested review from
JohanAhlen and
Harshg999
and removed request for
JohanAhlen
Harshg999
approved these changes
Oct 8, 2024
agl29
force-pushed
the
trino_logs
branch
2 times, most recently
from
5401dec
to
de4d616
Compare
tabraiz12
reviewed
Oct 10, 2024
| @@ -343,6 +343,11 @@ def _get_columns(self, database, table): | |||
| for col in columns | |||
| ] | |||
|
|
|||
| def get_log(self, notebook, snippet, startFrom=None, size=None): | |||
| guid = snippet['result']['handle']['guid'] if snippet.get('result') and snippet['result'].get('handle') and \ | |||
There was a problem hiding this comment.
startFrom, size and notebook are not used here, can that be removed?
tabraiz12
approved these changes
Oct 10, 2024
Harshg999
pushed a commit
that referenced
this pull request
Oct 14, 2024
- It accidentally got pushed with #3857.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?