Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding multicast implementation #292

Merged
merged 10 commits into from
Jan 29, 2020
Merged

Binding multicast implementation #292

merged 10 commits into from
Jan 29, 2020

Commits on Jan 27, 2020

  1. Fix scope warnings from golangci-lint 

    Signed-off-by: Alan Conway <[email protected]>
    @alanconway @slinkydeveloper
    alanconway authored and slinkydeveloper committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    a1f233d View commit details
    Browse the repository at this point in the history

  2. Added UnknownFormat to allow unknown formats to be forwarded. 

    Signed-off-by: Alan Conway <[email protected]>
    @alanconway @slinkydeveloper
    alanconway authored and slinkydeveloper committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    3055f3a View commit details
    Browse the repository at this point in the history

  3. Fix scope warnings from golangci-lint 

    Signed-off-by: Alan Conway <[email protected]>
    @alanconway @slinkydeveloper
    alanconway authored and slinkydeveloper committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    e0b9a1e View commit details
    Browse the repository at this point in the history

  4. Restore StructMessage, complete EventMessage implementation. 

    StructMessage and EventMessage are intended to be full implementations of the
Message interface that are independent of any transport and can be used to hold
a copy of a message in memory independently of the life of an incoming transport
message (e.g. for multicast, queuing etc.) CopyMessage copies an incoming
Message, the copy can be read many times and is independent of the original
message lifecycle (e.g. you might Finish() the original before you're done
multicasting the copy depending on policy)

They are a lot like your MockXMessages but they are not mocks, they're complete
Message implementations. Possibly there's some code overlap that can be cleaned up.

Please review the code carefully. I like what you've done to reduce copying but
there was a lot to take in, so this is a bit rushed.

One question: I intended for 2 types of message representation - Binary and
Structured. Message.Event() and EventMessage were really just implementations of
Binary encoding - not meant to be a third representation. I think you could drop
Message.Event() now that you have ToEvent(Message) so bindings only have to
implement the methods Structured() and Binary().

Signed-off-by: Alan Conway <[email protected]>
    @alanconway @slinkydeveloper
    alanconway authored and slinkydeveloper committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    415a945 View commit details
    Browse the repository at this point in the history

  5. Added WithAcksBeforeFinish 

    Signed-off-by: Francesco Guardiani <[email protected]>
    @slinkydeveloper
    slinkydeveloper committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    6ec4cdd View commit details
    Browse the repository at this point in the history

  6. Reverted uint32 to int32 

    Test integration CopyMessage + WithAcksBeforeFinish

Signed-off-by: Francesco Guardiani <[email protected]>
    @slinkydeveloper
    slinkydeveloper committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    7acc319 View commit details
    Browse the repository at this point in the history

  7. Fixed bunch of things 

    Added multi senders

Signed-off-by: Francesco Guardiani <[email protected]>
    @slinkydeveloper
    slinkydeveloper committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    9fcdcf0 View commit details
    Browse the repository at this point in the history

  8. General refactoring: 

    * CopyMessage moved in buffering submodule
* CopyMessage splitted to CopyMessage and BufferMessage (one binds the lifecycle, the other no)
* CopyMessage & BufferMessage implements buffer pooling to decrease memory allocations
* EventMessage, ToEvent & Transport adapter moved in event submodule

Signed-off-by: Francesco Guardiani <[email protected]>
    @slinkydeveloper
    slinkydeveloper committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    62bfa7b View commit details
    Browse the repository at this point in the history

  9. Added benchmark for BufferMessage 

    Signed-off-by: Francesco Guardiani <[email protected]>
    @slinkydeveloper
    slinkydeveloper committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    16c784f View commit details
    Browse the repository at this point in the history

  10. Removed context from binary buffered message 

    Signed-off-by: Francesco Guardiani <[email protected]>
    @slinkydeveloper
    slinkydeveloper committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    b766a97 View commit details
    Browse the repository at this point in the history