Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md #15

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

dmilov
Copy link
Contributor

@dmilov dmilov commented Apr 15, 2021

  • Adds TestsType parameter to build.ps1
  • Creates CONTRIBUTING guide
  • Updates README.md

Testing done:

.\build.ps1 -TestsType none
[9:21:22 AM] INFO: Publish CloudEvents.Sdk Module to 'C:\git-repos\github\sdk-powershell\CloudEvents.Sdk'
Microsoft (R) Build Engine version 16.9.0+57a23d249 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  All projects are up-to-date for restore.
  CloudEventsPowerShell -> C:\git-repos\github\sdk-powershell\src\CloudEventsPowerShell\bin\Release\netstandard2.0\CloudEventsPowerShell.dll
  CloudEventsPowerShell -> C:\git-repos\github\sdk-powershell\CloudEvents.Sdk\
.\build.ps1 -TestsType unit
[9:21:01 AM] INFO: Publish CloudEvents.Sdk Module to 'C:\git-repos\github\sdk-powershell\CloudEvents.Sdk'
Microsoft (R) Build Engine version 16.9.0+57a23d249 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  All projects are up-to-date for restore.
  CloudEventsPowerShell -> C:\git-repos\github\sdk-powershell\src\CloudEventsPowerShell\bin\Release\netstandard2.0\CloudEventsPowerShell.dll
  CloudEventsPowerShell -> C:\git-repos\github\sdk-powershell\CloudEvents.Sdk\
[9:21:02 AM] INFO: Run unit tests

Starting discovery in 9 files.                                                                                          Discovery finished in 861ms.                                                                                            [+] C:\git-repos\github\sdk-powershell\test\unit\ConvertFrom-HttpMessage.Tests.ps1 1.74s (702ms|826ms)                  [+] C:\git-repos\github\sdk-powershell\test\unit\ConvertTo-HttpMessage.Tests.ps1 546ms (202ms|228ms)                    [+] C:\git-repos\github\sdk-powershell\test\unit\New-CloudEvent.Tests.ps1 354ms (132ms|155ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Read-CloudEventData.Tests.ps1 314ms (87ms|165ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Read-CloudEventJsonData.Tests.ps1 452ms (238ms|152ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Read-CloudEventXmlData.Tests.ps1 436ms (231ms|141ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Set-CloudEventData.Tests.ps1 757ms (395ms|236ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Set-CloudEventJsonData.Tests.ps1 347ms (130ms|154ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Set-CloudEventXmlData.Tests.ps1 459ms (223ms|173ms)
Tests completed in 5.46s
Tests Passed: 28, Failed: 0, Skipped: 0 NotRun: 0
.\build.ps1 -TestsType integration
[9:21:12 AM] INFO: Publish CloudEvents.Sdk Module to 'C:\git-repos\github\sdk-powershell\CloudEvents.Sdk'
Microsoft (R) Build Engine version 16.9.0+57a23d249 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  All projects are up-to-date for restore.
  CloudEventsPowerShell -> C:\git-repos\github\sdk-powershell\src\CloudEventsPowerShell\bin\Release\netstandard2.0\CloudEventsPowerShell.dll
  CloudEventsPowerShell -> C:\git-repos\github\sdk-powershell\CloudEvents.Sdk\
[9:21:13 AM] INFO: Run integration tests

Starting discovery in 1 files.
Discovery finished in 265ms.
[+] C:\git-repos\github\sdk-powershell\test\integration\HttpIntegration.Tests.ps1 2.81s (1.67s|911ms)
Tests completed in 2.86s
Tests Passed: 5, Failed: 0, Skipped: 0 NotRun: 0
PS C:\git-repos\github\sdk-powershell> .\build.ps1 -TestsType none
[9:21:22 AM] INFO: Publish CloudEvents.Sdk Module to 'C:\git-repos\github\sdk-powershell\CloudEvents.Sdk'
Microsoft (R) Build Engine version 16.9.0+57a23d249 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  All projects are up-to-date for restore.
  CloudEventsPowerShell -> C:\git-repos\github\sdk-powershell\src\CloudEventsPowerShell\bin\Release\netstandard2.0\CloudEventsPowerShell.dll
  CloudEventsPowerShell -> C:\git-repos\github\sdk-powershell\CloudEvents.Sdk\
.\build.ps1
[9:20:43 AM] INFO: Publish CloudEvents.Sdk Module to 'C:\git-repos\github\sdk-powershell\CloudEvents.Sdk'
Microsoft (R) Build Engine version 16.9.0+57a23d249 for .NET                                                            Copyright (C) Microsoft Corporation. All rights reserved.                                                                                                                                                                                         Determining projects to restore...                                                                                      All projects are up-to-date for restore.
  CloudEventsPowerShell -> C:\git-repos\github\sdk-powershell\src\CloudEventsPowerShell\bin\Release\netstandard2.0\CloudEventsPowerShell.dll
  CloudEventsPowerShell -> C:\git-repos\github\sdk-powershell\CloudEvents.Sdk\
[9:20:44 AM] INFO: Run unit tests

Starting discovery in 9 files.
Discovery finished in 866ms.
[+] C:\git-repos\github\sdk-powershell\test\unit\ConvertFrom-HttpMessage.Tests.ps1 1.71s (725ms|781ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\ConvertTo-HttpMessage.Tests.ps1 530ms (209ms|241ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\New-CloudEvent.Tests.ps1 393ms (130ms|157ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Read-CloudEventData.Tests.ps1 336ms (107ms|164ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Read-CloudEventJsonData.Tests.ps1 429ms (214ms|151ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Read-CloudEventXmlData.Tests.ps1 455ms (248ms|144ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Set-CloudEventData.Tests.ps1 685ms (370ms|230ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Set-CloudEventJsonData.Tests.ps1 352ms (96ms|152ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Set-CloudEventXmlData.Tests.ps1 419ms (201ms|151ms)
Tests completed in 5.37s
Tests Passed: 28, Failed: 0, Skipped: 0 NotRun: 0
[9:20:51 AM] INFO: Run integration tests

Starting discovery in 1 files.
Discovery finished in 235ms.
[+] C:\git-repos\github\sdk-powershell\test\integration\HttpIntegration.Tests.ps1 2.69s (1.63s|859ms)
Tests completed in 2.73s
Tests Passed: 5, Failed: 0, Skipped: 0 NotRun: 0

Signed-off-by: Dimitar Milov [email protected]

Signed-off-by: Dimitar Milov <[email protected]>
Copy link
Member

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, approved. PTAL at the comment I made on the README. If you want to fix that with this PR, good with me. But feel free to create another PR if you want to fix it in a separate commit/PR.

README.md Show resolved Hide resolved
@embano1 embano1 changed the title Creates CONTRIBUTING.md Add CONTRIBUTING.md Apr 17, 2021
@dmilov dmilov merged commit 84606b0 into cloudevents:main Apr 19, 2021
@dmilov dmilov mentioned this pull request Apr 19, 2021
@dmilov dmilov deleted the topic/dmilov/contributing-guide branch April 26, 2021 05:37
@embano1 embano1 mentioned this pull request May 7, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants