Replace snafu with thiserror #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpiel
commented
Oct 27, 2020
| WrongEncoding {}, | ||
| #[snafu(display("{}", source))] | ||
| #[snafu(context(false))] | ||
| #[error(transparent)] |
There was a problem hiding this comment.
this will handle the impl of Display to the underlying error.
| @@ -23,11 +23,6 @@ | |||
| //! * [cloudevents-sdk-reqwest](https://docs.rs/cloudevents-sdk-reqwest): Integration with [reqwest](https://github.com/seanmonstar/reqwest) | |||
| //! | |||
|
|
|||
| extern crate serde; | |||
There was a problem hiding this comment.
no need for extern crate in the 2018 edition
elpiel
force-pushed
the
replace-snafu-with-thiserror
branch
2 times, most recently
from
245fa16
to
ab2008d
Compare
|
I'm also getting an unused import warning, maybe it's good to fix it as well? warning: unused import: `attributes::AttributesIter`
--> src/event/mod.rs:13:16
|
13 | pub(crate) use attributes::AttributesIter;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default |
|
@elpiel this should be fixed in another pr. let me merge them and rebase this one on top of master |
|
@elpiel can you rebase? |
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
elpiel
force-pushed
the
replace-snafu-with-thiserror
branch
from
ab2008d
to
eba7ee9
Compare
|
Should be done. |
|
Since it seems the no_std work is in progress, I'm gonna close this PR now (and i'm gonna close the issue too). @elpiel feel free to join in our cncf slack channel https://cloud-native.slack.com/archives/CTS0TCGVA to chat a little bit more about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #70
From what I see the difference between the two is not that big. If
no_stdhas more priority I would suggest to leavesnafufor the time being.