Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIPS support is broken for 32-bit non-windows platforms #65

Open
jyn514 opened this issue Feb 1, 2022 · 0 comments
Open

FIPS support is broken for 32-bit non-windows platforms #65

jyn514 opened this issue Feb 1, 2022 · 0 comments

Comments

@jyn514
Copy link
Contributor

jyn514 commented Feb 1, 2022

boring/boring-sys/build.rs

Lines 169 to 177 in 1507689

// Configure BoringSSL for building on 32-bit non-windows platforms.
if arch == "x86" && os != "windows" {
boringssl_cmake.define(
"CMAKE_TOOLCHAIN_FILE",
pwd.join(BORING_SSL_PATH)
.join("src/util/32-bit-toolchain.cmake")
.as_os_str(),
);
}

needs to instead be

                let toolchain_file = if cfg!(feature = "fips") {
                    format!("{}/util/32-bit-toolchain.cmake", BORING_SSL_DIR)
                } else {
                    format!("{}/src/util/32-bit-toolchain.cmake", BORING_SSL_DIR)
                };

                boringssl_cmake
                    .define("CMAKE_TOOLCHAIN_FILE", pwd.join(toolchain_file).as_os_str());
jyn514 added a commit that referenced this issue Feb 1, 2022
…ream-boring-merge

I intentionally retained the following changes:
- FIPS support for non-32-bit non-Windows platforms, see #65
- FIPS support for `X509StoreContextRef::chain`, see #66

Upstream has had roughly the following changes since the last merge:
- FIPS support
- Updated dependencies
- Git submodules are fetched automatically
- Support for pre-built versions of boringssl using `BORING_BSSL_PATH` and `BORING_BSSL_INCLUDE_PATH`
- Support for `HandshakeError::code` and `ClientHello::client_version`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant