Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also output sha256 digest when generating certificate #1063

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

izolight
Copy link
Contributor

The newkey and newcert endpoints now will print the sha256 digest in addition to md5 and sha1

@codecov-io
Copy link

codecov-io commented Nov 24, 2019

Codecov Report

Merging #1063 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
+ Coverage    56.4%   56.42%   +0.01%     
==========================================
  Files          76       76              
  Lines        7256     7258       +2     
==========================================
+ Hits         4093     4095       +2     
  Misses       2697     2697              
  Partials      466      466
Impacted Files Coverage Δ
api/generator/generator.go 33.97% <100%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe0199...b41fd33. Read the comment docs.

@lgarofalo lgarofalo self-requested a review March 25, 2020 21:00
@izolight
Copy link
Contributor Author

I just went through my open PRs and saw that this is approved but not merged.
Anything in the way for a merge?

@nickysemenza nickysemenza merged commit 6ea8605 into cloudflare:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants