Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enumerate service modes with explicit values #1249

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Enumerate service modes with explicit values #1249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deaa2f4
Enumerate service modes with constant values
da-cf Mar 27, 2023
0c3db86
update changelog entry
jacobbednarz Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/1249.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
devices_policy: update `Mode` field to use new `ServiceMode` string type with explicit const service mode values
```
14 changes: 12 additions & 2 deletions devices_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,19 @@ type DeviceClientCertificatesZone struct {
Result Enabled
}

type ServiceMode string

const (
oneDotOne ServiceMode = "1dot1"
warp ServiceMode = "warp"
proxy ServiceMode = "proxy"
postureOnly ServiceMode = "posture_only"
warpTunnelOnly ServiceMode = "warp_tunnel_only"
)

type ServiceModeV2 struct {
Mode string `json:"mode,omitempty"`
Port int `json:"port,omitempty"`
Mode ServiceMode `json:"mode,omitempty"`
Port int `json:"port,omitempty"`
}

type DeviceSettingsPolicy struct {
Expand Down