Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

slurm file only evaluated when validated cache changes #95

Open
reschke opened this issue Apr 14, 2021 · 0 comments · Fixed by bgp/stayrtr#17
Open

slurm file only evaluated when validated cache changes #95

reschke opened this issue Apr 14, 2021 · 0 comments · Fixed by bgp/stayrtr#17

Comments

@reschke
Copy link

reschke commented Apr 14, 2021

This is because updateFile exits early when fetching the cache yields a 304 (not modified), or if the hash of the cache did not change.

This is problematic for at least two reasons:

  • it might be necessary to update the SLURM file in an emergency, in which case changes should become visible quickly,
  • it makes testing/debugging extra hard (and the fact little activity is logged wrt slrum processing does not help).
ties added a commit to bgp/stayrtr that referenced this issue Aug 1, 2021
@ties
Refactor to update state when cache or SLURM changes
acbf96e 
Before this commit the new stayrtr state was only recalculated
when the validated cache changed.

This commit refactors the update loop and separates the actual
update from pulling the updated cache. The update is triggered
when the SLURM file changes _or_ when the validated cache changes.

Should fix cloudflare/gortr#95 and make
further changes that trigger an update when an update in the cache
has expired easier.
@ties ties mentioned this issue Aug 1, 2021
Merged
ties added a commit to bgp/stayrtr that referenced this issue Aug 1, 2021
@ties
Refactor to update state when cache or SLURM changes
32cee50 
Before this commit the new stayrtr state was only recalculated
when the validated cache changed.

This commit refactors the update loop and separates the actual
update from pulling the updated cache. The update is triggered
when the SLURM file changes _or_ when the validated cache changes.

Should fix cloudflare/gortr#95 and make
further changes that trigger an update when an update in the cache
has expired easier.
ties added a commit to bgp/stayrtr that referenced this issue Aug 1, 2021
@ties
Refactor to update state when cache or SLURM changes
d11bc15 
Before this commit the new stayrtr state was only recalculated
when the validated cache changed.

This commit refactors the update loop and separates the actual
update from pulling the updated cache. The update is triggered
when the SLURM file changes _or_ when the validated cache changes.

Should fix cloudflare/gortr#95 and make
further changes that trigger an update when an update in the cache
has expired easier.
job pushed a commit to bgp/stayrtr that referenced this issue Oct 20, 2021
@ties @job
Refactor to update state when cache or SLURM changes
03dff2d 
Before this commit the new stayrtr state was only recalculated
when the validated cache changed.

This commit refactors the update loop and separates the actual
update from pulling the updated cache. The update is triggered
when the SLURM file changes _or_ when the validated cache changes.

Should fix cloudflare/gortr#95 and make
further changes that trigger an update when an update in the cache
has expired easier.
@DonOtuseGH DonOtuseGH mentioned this issue Jan 12, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor to update state when cache or SLURM changes bgp/stayrtr
1 participant
@reschke