Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use line number from ParseError #1130

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Use line number from ParseError #1130

merged 1 commit into from
Oct 2, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.65.1-67-gf2485b1
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Oct 2, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   42.48m ± 3%   42.91m ± 1%       ~ (p=0.315 n=10)
CheckRules-4     8.559 ± 2%    8.543 ± 2%       ~ (p=0.481 n=10)
geomean         603.0m        605.4m       +0.41%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.41Mi ± 0%   27.41Mi ± 0%       ~ (p=0.280 n=10)
CheckRules-4    973.5Mi ± 0%   972.6Mi ± 0%       ~ (p=0.089 n=10)
geomean         163.3Mi        163.3Mi       -0.04%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.9k ± 0%   131.9k ± 0%       ~ (p=0.178 n=10)
CheckRules-4    14.18M ± 0%   14.17M ± 0%       ~ (p=0.105 n=10)
geomean         1.367M        1.367M       -0.02%

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.16%. Comparing base (b4eac86) to head (f2485b1).

Files with missing lines Patch % Lines
internal/parser/parser.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1130   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         102      102           
  Lines       10235    10236    +1     
=======================================
+ Hits         9740     9741    +1     
  Misses        346      346           
  Partials      149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit e10fa37 into main Oct 2, 2024
21 checks passed
@prymitive prymitive deleted the parseErr branch October 2, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants