Misc. build improvements #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The point of the feature is to build the vendored BoringSSL (i.e. we would still use BoringSSL, just not build it), so this name makes more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the non-default
no_bsslfeature with a defaultboringssl-vendoredone (so the logic is inverted: no_bssl disables building bssl when enabled, but boringssl-vendored enables building bssl when enabled). This makes more sense to me, as we build for BoringSSL even withno_bssl, it's just that we don't build BoringSSL itself.This also contains a bunch of other minor build tweaks.