Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrangler toml #11

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Add wrangler toml #11

merged 1 commit into from
Oct 22, 2019

Conversation

exvuma
Copy link
Contributor

@exvuma exvuma commented Oct 21, 2019

fixes #8

@exvuma
Copy link
Contributor Author

exvuma commented Oct 21, 2019

Couldn't add reviewers but ping @EverlastingBugstopper

@@ -0,0 +1,7 @@
name = "rust"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's maybe call this rust-worker to not confuse with type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention for templates is actually to have this be the same as the template name without "worker" because it'd get really redundant. Also, think to look at an account with all the scripts names ending in worker

@@ -0,0 +1,7 @@
name = "rust"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "rust"
name = "rust-worker"

@@ -0,0 +1,7 @@
name = "rust"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "rust"
name = "rust-hello-world"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@exvuma exvuma merged commit ce28a1c into cloudflare:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wrangler.toml with type
2 participants