-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrangler toml #11
Conversation
Couldn't add reviewers but ping @EverlastingBugstopper |
@@ -0,0 +1,7 @@ | |||
name = "rust" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's maybe call this rust-worker
to not confuse with type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The convention for templates is actually to have this be the same as the template name without "worker" because it'd get really redundant. Also, think to look at an account with all the scripts names ending in worker
@@ -0,0 +1,7 @@ | |||
name = "rust" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "rust" | |
name = "rust-worker" |
@@ -0,0 +1,7 @@ | |||
name = "rust" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "rust" | |
name = "rust-hello-world" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixes #8