resource/cloudflare_argo_tunnel: rename to cloudflare_tunnel

[jacobbednarz]

No description provided.

[github-actions]

changelog detected ✅

[jacobbednarz]

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareTunnelCreate_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareTunnelCreate_Basic
--- PASS: TestAccCloudflareTunnelCreate_Basic (7.60s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	8.160s
``

[github-actions]

This functionality has been released in v4.0.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[carl-armis]

Would like to request more information on the proposed migration path for this change.

It would be useful to have both resource type names supported to allow for us to properly migrated. The sudden removal creates a bit of a loop for us.

[AllexVeldman]

@jacobbednarz Renaming the resource fails in terraform with

│ Warning: Missing resource schema from provider
│ 
│ No resource schema found for cloudflare_argo_tunnel when decoding prior
│ state
╵
╷
│ Error: no schema available for module.cf-argo-tunnel.cloudflare_argo_tunnel.argo-tunnel while reading state; this is a bug in Terraform and should be reported
│ 
│ 

As there is no version with both cloudflare_argo_tunnel and cloudflare_tunnel the only upgrade path we have is remove existing tunnel on v3, update, re-add tunnel in v4.

See https://developer.hashicorp.com/terraform/plugin/sdkv2/best-practices/deprecations#provider-data-source-or-resource-rename.

[afreyermuth98]

@jacobbednarz @AllexVeldman @carl-armis
Maybe we'll have more visibility if we re-open a new issue on this subject ? Because talking on a merged PR doesn't seem to be efficient :/

[AllexVeldman]

I'm lucky to be in the position where I could destroy and recreate the tunnel and dependant resources.
But I agree an Issue makes this more visible.