Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service mode v2 type and docs for usage #2331

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Update service mode v2 type and docs for usage #2331

merged 4 commits into from
Mar 30, 2023

Conversation

imdawon
Copy link
Contributor

@imdawon imdawon commented Mar 27, 2023

Depends on cloudflare-go PR: cloudflare/cloudflare-go#1249

Updates ServiceModeV2 type and updates docs with all valid values.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023 •
edited
Loading

changelog detected ✅

@jacobbednarz jacobbednarz mentioned this pull request Mar 30, 2023
Merged
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareDeviceSettingsPolicy_" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareDeviceSettingsPolicy_Create
--- PASS: TestAccCloudflareDeviceSettingsPolicy_Create (38.53s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	39.305s

@jacobbednarz jacobbednarz merged commit 90e694e into cloudflare:master Mar 30, 2023
@github-actions github-actions bot added this to the v4.3.0 milestone Mar 30, 2023
github-actions bot pushed a commit that referenced this pull request Mar 30, 2023
Update CHANGELOG.md for #2331
44c35da
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

This functionality has been released in v4.3.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@imdawon @jacobbednarz @da-cf