Skip to content

Commit

Permalink
Remove direct use of v8::Exception::Error in queue-test
Browse files Browse the repository at this point in the history
  • Loading branch information
jasnell committed Sep 1, 2023
1 parent 3c31eb1 commit 0c5f644
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/workerd/api/streams/queue-test.c++
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ KJ_TEST("ValueQueue erroring works") {

ValueQueue queue(2);

queue.error(js, js.v8Ref(v8::Exception::Error(jsg::v8StrIntern(js.v8Isolate, "boom"_kj))));
queue.error(js, js.v8Ref(js.v8Error("boom"_kj)));

KJ_ASSERT(queue.desiredSize() == 0);

Expand Down Expand Up @@ -333,7 +333,7 @@ KJ_TEST("ValueQueue errors consumer with multiple-reads") {
read(js, consumer).then(js, readContinuation, errorContinuation);
read(js, consumer).then(js, readContinuation, errorContinuation);

queue.error(js, js.v8Ref(v8::Exception::Error(jsg::v8StrIntern(js.v8Isolate, "boom"_kj))));
queue.error(js, js.v8Ref(js.v8Error("boom"_kj)));

js.runMicrotasks();
}
Expand Down Expand Up @@ -417,7 +417,7 @@ KJ_TEST("ByteQueue erroring works") {

ByteQueue queue(2);

queue.error(js, js.v8Ref(v8::Exception::Error(jsg::v8StrIntern(js.v8Isolate, "boom"_kj))));
queue.error(js, js.v8Ref(js.v8Error("boom"_kj)));

KJ_ASSERT(queue.desiredSize() == 0);

Expand Down

0 comments on commit 0c5f644

Please sign in to comment.