add missing Certificate to crypto export default (#2739)

cloudflare · Sep 18, 2024 · 57db380 · 57db380
1 parent 442762b
commit 57db380
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/node/crypto.ts b/src/node/crypto.ts
@@ -239,6 +239,8 @@ export default {
   // WebCrypto
   subtle,
   webcrypto,
+  // Spkac
+  Certificate,
   // X509
   X509Certificate,
 };

diff --git a/src/workerd/api/node/tests/crypto_x509-test.js b/src/workerd/api/node/tests/crypto_x509-test.js
@@ -29,6 +29,7 @@
 import { deepStrictEqual, ok, strictEqual, throws } from 'node:assert';
 
 import { Buffer } from 'node:buffer';
+import assert from 'node:assert';
 
 import { X509Certificate, PublicKeyObject } from 'node:crypto';
 
@@ -348,3 +349,11 @@ export const test_ok = {
 //     throws(() => new X509Certificate(badCert));
 //   }
 // };
+
+// Ref: https://github.com/unjs/unenv/pull/310
+export const shouldImportCertificate = {
+  test() {
+    // This is allowed by Node.js as well.
+    assert(process.getBuiltinModule('crypto').Certificate);
+  },
+};