Skip to content

Commit

Permalink
Update V8 to 11.6
Browse files Browse the repository at this point in the history
  • Loading branch information
fhanau committed Jul 28, 2023
1 parent 2643fbd commit 6b19807
Show file tree
Hide file tree
Showing 14 changed files with 102 additions and 102 deletions.
24 changes: 12 additions & 12 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -296,34 +296,34 @@ npm_repositories()

git_repository(
name = "v8",
commit = "84b0aff45ebe07dce522d2c90b42074b25b60927",
commit = "578812b037096e4026447ee449786b60333b00d3",
patch_args = ["-p1"],
patches = [
"//:patches/v8/0001-Allow-manually-setting-ValueDeserializer-format-vers.patch",
"//:patches/v8/0002-Allow-manually-setting-ValueSerializer-format-versio.patch",
"//:patches/v8/0003-Make-icudata-target-public.patch",
"//:patches/v8/0004-Add-ArrayBuffer-MaybeNew.patch",
"//:patches/v8/0005-Fix-v8-code_generator-imports.patch",
"//:patches/v8/0006-Allow-Windows-builds-under-Bazel.patch",
"//:patches/v8/0007-Disable-bazel-whole-archive-build.patch",
"//:patches/v8/0008-Make-v8-Locker-automatically-call-isolate-Enter.patch",
"//:patches/v8/0009-Add-an-API-to-capture-and-restore-the-cage-base-poin.patch",
"//:patches/v8/0010-Speed-up-V8-bazel-build-by-always-using-target-cfg.patch",
"//:patches/v8/0011-Implement-Promise-Context-Tagging.patch",
"//:patches/v8/0012-Enable-V8-shared-linkage.patch",
"//:patches/v8/0005-Allow-Windows-builds-under-Bazel.patch",
"//:patches/v8/0006-Disable-bazel-whole-archive-build.patch",
"//:patches/v8/0007-Make-v8-Locker-automatically-call-isolate-Enter.patch",
"//:patches/v8/0008-Add-an-API-to-capture-and-restore-the-cage-base-poin.patch",
"//:patches/v8/0009-Speed-up-V8-bazel-build-by-always-using-target-cfg.patch",
"//:patches/v8/0010-Implement-Promise-Context-Tagging.patch",
"//:patches/v8/0011-Enable-V8-shared-linkage.patch",
"//:patches/v8/0012-Fix-ICU-build.patch",
],
remote = "https://chromium.googlesource.com/v8/v8.git",
shallow_since = "1685722300 +0000",
shallow_since = "1690276460 +0000",
)

new_git_repository(
name = "com_googlesource_chromium_icu",
build_file = "@v8//:bazel/BUILD.icu",
commit = "a2961dc659b4ae847a9c6120718cc2517ee57d9e",
commit = "e8c3bc9ea97d4423ad0515e5f1c064f486dae8b1",
patch_cmds = ["find source -name BUILD.bazel | xargs rm"],
patch_cmds_win = ["Get-ChildItem -Path source -File -Include BUILD.bazel -Recurse | Remove-Item"],
remote = "https://chromium.googlesource.com/chromium/deps/icu.git",
shallow_since = "1683080067 +0000",
shallow_since = "1686777134 +0000"
)

new_git_repository(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From b2d96e0619b4b37345fe4e40408d3776cb60cd1f Mon Sep 17 00:00:00 2001
From 4b56ec11d01ce9d18620635036e263e8c45bd95d Mon Sep 17 00:00:00 2001
From: Alex Robinson <[email protected]>
Date: Wed, 2 Mar 2022 15:58:04 -0600
Subject: Allow manually setting ValueDeserializer format version
Expand Down Expand Up @@ -40,10 +40,10 @@ index 0cb3e045bc46ec732956318b980e749d1847d06d..40ad805c7970cc9379e69f046205836d
* Reads raw data in various common formats to the buffer.
* Note that integer types are read in base-128 varint format, not with a
diff --git a/src/api/api.cc b/src/api/api.cc
index f19e07ff75bd818f41f2527ac6a210a8663fcc76..093acb75a733fc0e1234108014543fccca5bc73a 100644
index a510fe68e68530cd6ea019ee6ccb0d142a586770..ab988d54d3af14abb876d97232fa5a39eb838032 100644
--- a/src/api/api.cc
+++ b/src/api/api.cc
@@ -3783,6 +3783,10 @@ uint32_t ValueDeserializer::GetWireFormatVersion() const {
@@ -3789,6 +3789,10 @@ uint32_t ValueDeserializer::GetWireFormatVersion() const {
return private_->deserializer.GetWireFormatVersion();
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From ba9b1a772f71fa100aac297b8d2e043c0034a870 Mon Sep 17 00:00:00 2001
From e480982cb9311de5092093b267b81b94ed416834 Mon Sep 17 00:00:00 2001
From: James M Snell <[email protected]>
Date: Wed, 16 Mar 2022 08:59:21 -0700
Subject: Allow manually setting ValueSerializer format version
Expand Down Expand Up @@ -28,10 +28,10 @@ index 40ad805c7970cc9379e69f046205836dbd760373..596be18adeb3a5a81794aaa44b1d347d
* Writes out a header, which includes the format version.
*/
diff --git a/src/api/api.cc b/src/api/api.cc
index 093acb75a733fc0e1234108014543fccca5bc73a..bddda91dbb07500eac71274fe859603a416821b8 100644
index ab988d54d3af14abb876d97232fa5a39eb838032..64d45bd0fafe018571e34662eceffc31f3ccfe69 100644
--- a/src/api/api.cc
+++ b/src/api/api.cc
@@ -3650,6 +3650,10 @@ ValueSerializer::ValueSerializer(Isolate* v8_isolate, Delegate* delegate)
@@ -3656,6 +3656,10 @@ ValueSerializer::ValueSerializer(Isolate* v8_isolate, Delegate* delegate)

ValueSerializer::~ValueSerializer() { delete private_; }

Expand All @@ -43,7 +43,7 @@ index 093acb75a733fc0e1234108014543fccca5bc73a..bddda91dbb07500eac71274fe859603a

void ValueSerializer::SetTreatArrayBufferViewsAsHostObjects(bool mode) {
diff --git a/src/objects/value-serializer.cc b/src/objects/value-serializer.cc
index b7c2c02b283043fe40c8c1b799b00da92e6d41ab..e2628a265b1b4f88fd30448fa8198468a4e58776 100644
index f13ce1e7ebd115c383dcf03e6a0e392b282d86ee..bcf0692f62116196d9d5cba0633ef553d16f7c32 100644
--- a/src/objects/value-serializer.cc
+++ b/src/objects/value-serializer.cc
@@ -266,6 +266,7 @@ ValueSerializer::ValueSerializer(Isolate* isolate,
Expand Down
2 changes: 1 addition & 1 deletion patches/v8/0003-Make-icudata-target-public.patch
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 77c635804ca6e9351f52eff90730ee952db64d5b Mon Sep 17 00:00:00 2001
From 476fd6163a1352f9855652dfd913e0ffc180cc33 Mon Sep 17 00:00:00 2001
From: Kenton Varda <[email protected]>
Date: Sat, 17 Sep 2022 11:11:15 -0500
Subject: Make `:icudata` target public.
Expand Down
2 changes: 1 addition & 1 deletion patches/v8/0004-Add-ArrayBuffer-MaybeNew.patch
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From c50f777c04d9e10b25311910dd4439398a2fc852 Mon Sep 17 00:00:00 2001
From 19bff3c9180e93eef7eaeb1d58f758afafb8d083 Mon Sep 17 00:00:00 2001
From: Kenton Varda <[email protected]>
Date: Fri, 16 Sep 2022 21:41:45 -0500
Subject: Add `ArrayBuffer::MaybeNew()`.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 29c35c6848cd9e3a7e6d5e570dc62131aaab5baf Mon Sep 17 00:00:00 2001
From 7c312b357a7bff99eebc4ce0a597803a6808b132 Mon Sep 17 00:00:00 2001
From: Brendan Coll <[email protected]>
Date: Thu, 16 Mar 2023 11:56:10 +0000
Subject: Allow Windows builds under Bazel
Expand All @@ -10,42 +10,42 @@ Subject: Allow Windows builds under Bazel
3 files changed, 84 insertions(+), 12 deletions(-)

diff --git a/BUILD.bazel b/BUILD.bazel
index 9d1a83a1ee1b9184daa6f9b1c48bdd28bac082f9..68480f5461d3afa1c826ca8cd929cdc7d44882b0 100644
index ba1a415eb2788b677e870e19b79a90eefc04a2a3..daca711d846c00059492f8cf56ac813b708a4501 100644
--- a/BUILD.bazel
+++ b/BUILD.bazel
@@ -672,6 +672,7 @@ filegroup(
@@ -682,6 +682,7 @@ filegroup(
"src/base/platform/mutex.h",
"src/base/platform/platform.cc",
"src/base/platform/platform.h",
+ "src/base/platform/platform-posix.h", # Always included by src/execution/isolate.h
"src/base/platform/semaphore.cc",
"src/base/platform/semaphore.h",
"src/base/platform/time.cc",
@@ -711,7 +712,6 @@ filegroup(
@@ -721,7 +722,6 @@ filegroup(
] + select({
"@v8//bazel/config:is_posix": [
"src/base/platform/platform-posix.cc",
- "src/base/platform/platform-posix.h",
"src/base/platform/platform-posix-time.cc",
"src/base/platform/platform-posix-time.h",
],
@@ -734,6 +734,7 @@ filegroup(
@@ -744,6 +744,7 @@ filegroup(
"@v8//bazel/config:is_windows": [
"src/base/debug/stack_trace_win.cc",
"src/base/platform/platform-win32.cc",
+ "src/base/platform/platform-win32.h",
"src/base/win32-headers.h",
],
}),
@@ -1105,6 +1106,7 @@ filegroup(
@@ -1120,6 +1121,7 @@ filegroup(
"include/v8-wasm-trap-handler-posix.h",
"src/api/api.cc",
"src/api/api.h",
+ "include/v8-wasm-trap-handler-win.h",
"src/api/api-arguments.cc",
"src/api/api-arguments.h",
"src/api/api-arguments-inl.h",
@@ -2478,6 +2480,11 @@ filegroup(
@@ -2503,6 +2505,11 @@ filegroup(
"src/trap-handler/handler-inside-posix.cc",
"src/trap-handler/handler-outside-posix.cc",
],
Expand All @@ -57,7 +57,7 @@ index 9d1a83a1ee1b9184daa6f9b1c48bdd28bac082f9..68480f5461d3afa1c826ca8cd929cdc7
"//conditions:default": [],
}) + select({
"@v8//bazel/config:v8_arm64_simulator": [
@@ -2485,13 +2492,6 @@ filegroup(
@@ -2510,13 +2517,6 @@ filegroup(
"src/trap-handler/trap-handler-simulator.h",
],
"//conditions:default": [],
Expand All @@ -71,7 +71,7 @@ index 9d1a83a1ee1b9184daa6f9b1c48bdd28bac082f9..68480f5461d3afa1c826ca8cd929cdc7
}) + select({
"@v8//bazel/config:is_windows_64bit": [
"src/diagnostics/unwinding-info-win64.cc",
@@ -3318,6 +3318,9 @@ filegroup(
@@ -3346,6 +3346,9 @@ filegroup(
"@v8//bazel/config:is_msvc_asm_ia32": ["src/heap/base/asm/ia32/push_registers_masm.asm"],
"@v8//bazel/config:is_msvc_asm_x64": ["src/heap/base/asm/x64/push_registers_masm.asm"],
"@v8//bazel/config:is_msvc_asm_arm64": ["src/heap/base/asm/arm64/push_registers_masm.S"],
Expand All @@ -81,7 +81,7 @@ index 9d1a83a1ee1b9184daa6f9b1c48bdd28bac082f9..68480f5461d3afa1c826ca8cd929cdc7
}),
)

@@ -3671,9 +3674,11 @@ filegroup(
@@ -3695,9 +3698,11 @@ filegroup(
"src/d8/d8-js.cc",
"src/d8/d8-platforms.cc",
"src/d8/d8-platforms.h",
Expand All @@ -95,7 +95,7 @@ index 9d1a83a1ee1b9184daa6f9b1c48bdd28bac082f9..68480f5461d3afa1c826ca8cd929cdc7
)

genrule(
@@ -3985,7 +3990,7 @@ py_test(
@@ -4009,7 +4014,7 @@ py_test(
":noicu/d8",
":noicu/v8_build_config",
"//testing/pybase",
Expand All @@ -104,7 +104,7 @@ index 9d1a83a1ee1b9184daa6f9b1c48bdd28bac082f9..68480f5461d3afa1c826ca8cd929cdc7
main = "tools/run-tests.py",
python_version = "PY3",
tags = [
@@ -4015,7 +4020,7 @@ py_test(
@@ -4039,7 +4044,7 @@ py_test(
":icu/d8",
":icu/v8_build_config",
"//testing/pybase",
Expand Down
25 changes: 0 additions & 25 deletions patches/v8/0005-Fix-v8-code_generator-imports.patch

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 40b749ea96fcc95a63a4d3a4bcca5dc5474d7180 Mon Sep 17 00:00:00 2001
From e42ca0d1ef84b0627bc24eabbbbe530ea2bf49ed Mon Sep 17 00:00:00 2001
From: Felix Hanau <[email protected]>
Date: Tue, 11 Apr 2023 14:41:31 -0400
Subject: Disable bazel whole-archive build
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 9fbfa1ab0ce695ec96a5a01f721b5c696ba8ceb8 Mon Sep 17 00:00:00 2001
From ad4178ec8b97b7b31a923cb154fda05385c3f08c Mon Sep 17 00:00:00 2001
From: Kenton Varda <[email protected]>
Date: Tue, 23 May 2023 09:18:57 -0500
Subject: Make v8::Locker automatically call isolate->Enter().
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 7414b4dd9f0855651c9907e93ea272265d798af1 Mon Sep 17 00:00:00 2001
From ef816c90859a9fa0efb2292a087d82281766f1a0 Mon Sep 17 00:00:00 2001
From: Kenton Varda <[email protected]>
Date: Tue, 23 May 2023 09:24:11 -0500
Subject: Add an API to capture and restore the cage base pointers.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 3a11c0c287505a74d0ad028b55db2a696729a80e Mon Sep 17 00:00:00 2001
From 6535d61fbad30298d8276e5587ebf08cf656b4a2 Mon Sep 17 00:00:00 2001
From: Felix Hanau <[email protected]>
Date: Wed, 7 Jun 2023 21:40:54 -0400
Subject: Speed up V8 bazel build by always using target cfg
Expand All @@ -16,7 +16,7 @@ this also improves build times.
2 files changed, 130 insertions(+), 135 deletions(-)

diff --git a/BUILD.bazel b/BUILD.bazel
index 68480f5461d3afa1c826ca8cd929cdc7d44882b0..f1a0121373eae1102e057252d5048331fe9b810c 100644
index daca711d846c00059492f8cf56ac813b708a4501..8fdd538768efb73498542f523fe3bbf12610bd78 100644
--- a/BUILD.bazel
+++ b/BUILD.bazel
@@ -16,8 +16,8 @@ load(
Expand All @@ -30,7 +30,7 @@ index 68480f5461d3afa1c826ca8cd929cdc7d44882b0..f1a0121373eae1102e057252d5048331
)
load(":bazel/v8-non-pointer-compression.bzl", "v8_binary_non_pointer_compression")

@@ -3531,10 +3531,42 @@ filegroup(
@@ -3559,10 +3559,42 @@ filegroup(
# Generated files
# =================================================

Expand Down Expand Up @@ -75,7 +75,7 @@ index 68480f5461d3afa1c826ca8cd929cdc7d44882b0..f1a0121373eae1102e057252d5048331
args = select({
":is_v8_annotate_torque_ir": ["-annotate-ir"],
"//conditions:default": [],
@@ -3542,7 +3574,13 @@ v8_torque_definitions(
@@ -3570,7 +3602,13 @@ v8_torque_definitions(
"@v8//bazel/config:v8_target_is_32_bits": ["-m32"],
"//conditions:default": [],
}),
Expand All @@ -90,7 +90,7 @@ index 68480f5461d3afa1c826ca8cd929cdc7d44882b0..f1a0121373eae1102e057252d5048331
"bit-fields.h",
"builtin-definitions.h",
# "class-debug-readers.cc",
@@ -3559,25 +3597,7 @@ v8_torque_definitions(
@@ -3587,25 +3625,7 @@ v8_torque_definitions(
"objects-body-descriptors-inl.inc",
"objects-printer.cc",
"visitor-lists.h",
Expand All @@ -116,7 +116,7 @@ index 68480f5461d3afa1c826ca8cd929cdc7d44882b0..f1a0121373eae1102e057252d5048331
],
icu_srcs = [":icu/torque_files"],
noicu_srcs = [":noicu/torque_files"],
@@ -3681,22 +3701,20 @@ filegroup(
@@ -3705,22 +3725,20 @@ filegroup(
}),
)

Expand Down Expand Up @@ -145,7 +145,7 @@ index 68480f5461d3afa1c826ca8cd929cdc7d44882b0..f1a0121373eae1102e057252d5048331
)

v8_mksnapshot(
@@ -3873,8 +3891,6 @@ v8_binary(
@@ -3897,8 +3915,6 @@ v8_binary(
srcs = [
"src/regexp/gen-regexp-special-case.cc",
"src/regexp/special-case.h",
Expand All @@ -154,7 +154,7 @@ index 68480f5461d3afa1c826ca8cd929cdc7d44882b0..f1a0121373eae1102e057252d5048331
],
copts = ["-Wno-implicit-fallthrough"],
defines = [
@@ -3885,6 +3901,7 @@ v8_binary(
@@ -3909,6 +3925,7 @@ v8_binary(
"UNISTR_FROM_CHAR_EXPLICIT=",
],
deps = [
Expand Down
Loading

0 comments on commit 6b19807

Please sign in to comment.