Prevent ws send() after hibernation #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Aug 10, 2023
| IoOwn<WebSocket::Native> WebSocket::initNative( | ||
| IoContext& ioContext, | ||
| kj::WebSocket& ws, | ||
| bool closedOutgoingConn) { |
There was a problem hiding this comment.
Non-blocking Nit: generally not a fan of bool arguments. This one admittedly isn't too bad since the call site is not passing true or false but still, as a general rule I have a strong preference for using enum args or options structs here so that call sites are more self documenting...
e.g.
initNative(ct, ws, Options::CLOSED_OUTGOING_CONNECTION)
// as opposed to
initNative(ct, ws, true)There was a problem hiding this comment.
I agree, but in this case there's only one call site and it's practically "moving" Native::closedOutgoing back into the api::WebSocket upon construction. If it were slightly more complicated I'd opt for the enum.
If a client does not honor a close message sent from a DO, we will not receive a close from the client. We need to keep track of the fact the DO's websocket sent a close, otherwise we will allow the websocket to send() again once it wakes from hibernation.
MellowYarker
force-pushed
the
milan/hib-ws-close-update
branch
from
37ae55d
to
9bb0472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client does not honor a close message sent from a DO, we will not receive a close from the client. We need to keep track of the fact the DO's websocket sent a close, otherwise we will allow the websocket to send() again once it wakes from hibernation.