Implement jsg::JsValue and related types #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/jsvalue
branch
4 times, most recently
from
cea56f0
to
b33f45d
Compare
|
@mrbbot ... just a heads up on this. we'll need to make sure the type mappings are generated correctly |
jasnell
force-pushed
the
jsnell/jsvalue
branch
from
b33f45d
to
edde180
Compare
jasnell
commented
Aug 16, 2023
kentonv
reviewed
Aug 17, 2023
jasnell
force-pushed
the
jsnell/jsvalue
branch
5 times, most recently
from
570d259
to
a848863
Compare
kentonv
reviewed
Aug 18, 2023
jasnell
force-pushed
the
jsnell/jsvalue
branch
2 times, most recently
from
e01f9e2
to
0480b48
Compare
kentonv
approved these changes
Aug 20, 2023
jasnell
force-pushed
the
jsnell/jsvalue
branch
from
0480b48
to
280b2b9
Compare
These are a new abstraction meant to discourage use of v8::Local<T> directly in most cases.
jasnell
force-pushed
the
jsnell/jsvalue
branch
from
280b2b9
to
4217006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a new abstraction meant to discourage use of v8::Local directly in most cases.
See the included test for examples of use.
PR includes changes to
AbortSignal/AbortControllerto illustrate how it is used and to verify it works.Still todo:Update the RTTI handling to ensure typescript type generation for the Js* types works as expectedMore documentation