JSG Completion: Use jsg::JsValue with jsg serializer/deserializer #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/jsg-completion-serdes
branch
from
a3eb99f
to
dd8e09b
Compare
ohodson
reviewed
Aug 23, 2023
ohodson
reviewed
Aug 23, 2023
jasnell
force-pushed
the
jsnell/jsg-completion-serdes
branch
2 times, most recently
from
cfa1207
to
ae75f7a
Compare
Also require that both be allocated on the stack.
jasnell
force-pushed
the
jsnell/jsg-completion-serdes
branch
from
ae75f7a
to
4377f32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.