Temporary update to LLVM 16 on Windows

[ohodson]

No description provided.

[jasnell]

Assuming the experiment works, this LGTM

[ohodson]

Need to up my foo with the yaml here, fingers crossed.

…

On Tue, Aug 29, 2023 at 3:32 PM James M Snell ***@***.***> wrote: ***@***.**** approved this pull request. Assuming the experiment works, this LGTM — Reply to this email directly, view it on GitHub <#1079 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABACZOWYUATHKZ2MY2X3XUTXXX4O3ANCNFSM6AAAAAA4C7F3K4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ohodson]

Github action language...my PR here breaks Linux / Mac which then fail before the Windows build can get going...would like to specialize the execution flow for Windows vs Unix...it's going to be trivial once you know the runes...

[fhanau]

Issue is actions/runner-images#8125 (comment)

[ohodson]

Still failing with LLVM 16:

ERROR: C:/users/runneradmin/_bazel_runneradmin/hs7imhxj/external/capnp-cpp/src/kj/BUILD.bazel:5:11: Compiling src/kj/units.c++ failed: undeclared inclusion(s) in rule '@capnp-cpp//src/kj:kj':
this rule is missing dependency declarations for the following files included by 'src/kj/units.c++':
  'C:/Program Files/LLVM/lib/clang/16/include/stddef.h'
  'C:/Program Files/LLVM/lib/clang/16/include/__stddef_max_align_t.h'
  'C:/Program Files/LLVM/lib/clang/16/include/vadefs.h'
  'C:/Program Files/LLVM/lib/clang/16/include/stddef.h'
  'C:/Program Files/LLVM/lib/clang/16/include/intrin.h'
  'C:/Program Files/LLVM/lib/clang/16/include/x86intrin.h'
  'C:/Program Files/LLVM/lib/clang/16/include/ia32intrin.h'
  'C:/Program Files/LLVM/lib/clang/16/include/immintrin.h'
  'C:/Program Files/LLVM/lib/clang/16/include/x86gprintrin.h'

[ohodson]

Compiling src/kj/units.c++ failed: undeclared inclusion(s) in rule '@capnp-cpp//src/kj:kj':
this rule is missing dependency declarations for the following files included by

Looks similar to #41, adding test.yml to the files hashed for the cache to invalidate it.

[ohodson]

From experimenting locally at home, this issue repros perfectly after upgrading to LLVM 16 (winget upgrade LLVM).

The underlying problem with LLVM 16 has been reported here:
bazelbuild/bazel#17863

Renaming C:\Program Files\LLVM\lib\clang\16 to C:\Program Files\LLVM\lib\clang\16.0.6 unblocks the errors we've seen in our runner when trying to move to LLVM16, but then we have new static assertion failures. Without looking into this any further today, it may be that a later Windows Kit does not have this issue.

external/v8/src/base/platform/platform-win32.cc(52,15): error: static assertion expression is not an integral constant expression
static_assert(offsetof(V8_CRITICAL_SECTION, DebugInfo) ==
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt\stddef.h(47,31): note: expanded from macro 'offsetof'      
        #define offsetof(s,m) ((::size_t)&reinterpret_cast<char const volatile&>((((s*)0)->m)))
                              ^
external/v8/src/base/platform/platform-win32.cc(52,15): note: cast that performs the conversions of a reinterpret_cast is not allowed in a constant expression
C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt\stddef.h(47,32): note: expanded from macro 'offsetof'      
        #define offsetof(s,m) ((::size_t)&reinterpret_cast<char const volatile&>((((s*)0)->m)))
                               ^
external/v8/src/base/platform/platform-win32.cc(54,15): error: static assertion expression is not an integral constant expression
static_assert(offsetof(V8_CRITICAL_SECTION, LockCount) ==
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt\stddef.h(47,31): note: expanded from macro 'offsetof'      
        #define offsetof(s,m) ((::size_t)&reinterpret_cast<char const volatile&>((((s*)0)->m)))
                              ^
external/v8/src/base/platform/platform-win32.cc(54,15): note: cast that performs the conversions of a reinterpret_cast is not allowed in a constant expression
C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt\stddef.h(47,32): note: expanded from macro 'offsetof'      
        #define offsetof(s,m) ((::size_t)&reinterpret_cast<char const volatile&>((((s*)0)->m)))

[ohodson]

Dropping this in favour of #1092