Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for githooks configuration on Windows #1110

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Conversation

ohodson
Copy link
Contributor

@ohodson ohodson commented Sep 1, 2023

Follow-up to #1059 and #1060

This PR moves build/scripts/workspace-status.sh to tools/unix/workspace-status.sh and adds a cmd.exe script, ,tools/windows/workspace-status.cmd, that invokes it on Windows. The latter script is just a wrapper that finds the bash.exe that comes in the Git installation on Windows and uses it to invoke the existing workspace-status.sh script.

git itself appears to run the existing githooks/ with bash.exe so no changes seem likely there.

@ohodson ohodson force-pushed the orion/win-githooks branch 2 times, most recently from d03a51b to a6f0ce1 Compare September 1, 2023 14:25
@ohodson ohodson requested a review from mikea September 1, 2023 14:30
@ohodson ohodson force-pushed the orion/win-githooks branch 3 times, most recently from 75fb464 to 8da4942 Compare September 1, 2023 16:22
Move build/scripts/workspace-status.sh to
tools/unix/workspace-status.sh.
This is just a wrapper that invokes bash to run
`tools/unix/workspace-status.sh`.

Follow-up to #1059
and #1060
Copy link
Collaborator

@mikea mikea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for handling this

@ohodson ohodson merged commit 8aabe6a into main Sep 1, 2023
7 checks passed
@ohodson ohodson deleted the orion/win-githooks branch September 1, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants