Update multiple KJ_IF_MAYBE uses to KJ_IF_SOME in workerd/api #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
approved these changes
Sep 8, 2023
| JSG_REQUIRE(kj::Url::tryParse(url, kj::Url::HTTP_PROXY_REQUEST, urlOptions) != kj::none, | ||
| TypeError, "Invalid URL. Cache API keys must be fully-qualified, valid URLs."); | ||
|
|
||
| return url; |
There was a problem hiding this comment.
hmm, maybe this isn't feasible or at least not trivial, but while we're changing kj::Maybe semantics, I wonder if we could also make the kj::Maybe<T> to T conversion explicit? Maybe this was already discussed and I missed it, if so apologies.
ohodson
approved these changes
Sep 8, 2023
jasnell
force-pushed
the
jsnell/kj-if-some-conversions
branch
from
f9773e4
to
aaf12c1
Compare
jasnell
force-pushed
the
jsnell/kj-if-some-conversions
branch
from
aaf12c1
to
d92776b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.