Revert "Merge pull request #1042 from cloudflare/harris/kj-stack-arra… #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: capnproto/capnproto#1794 |
harrishancock
force-pushed
the
harris/revert-small-array-mainline
branch
2 times, most recently
from
d66eae2
to
38e747e
Compare
…y-no-longer-supports-vlas" This reverts commit 028bdc6, reversing changes made to 8aabe6a. Instead of reverting our capnproto dependency back to what it was before the KJ_STACK_ARRAY removal PR, I have instead bumped it to a capnproto commit which is based on its origin/v2 branch, with the KJ_STACK_ARRAY revert on top. The capnproto update also includes reverts for the following two capnproto PRs, which caused tests failures in our downstream internal code. capnproto/capnproto#1774 capnproto/capnproto#1786
harrishancock
force-pushed
the
harris/revert-small-array-mainline
branch
from
38e747e
to
6a066fa
Compare
jasnell
approved these changes
Sep 8, 2023
ohodson
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y-no-longer-supports-vlas"
This reverts commit 028bdc6, reversing changes made to 8aabe6a.
Instead of reverting our capnproto dependency back to what it was before the KJ_STACK_ARRAY removal PR, I have instead bumped it to a capnproto commit which is based on its origin/v2 branch, with the KJ_STACK_ARRAY revert on top.