Revert "Merge pull request #1033 from cloudflare/bcaimano/actor-cache-no-state #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Sep 8, 2023
bcaimano
added a commit
that referenced
this pull request
Sep 14, 2023
…r ActorCache::Entries with bugfix (#1162) * Revert "Merge pull request #1155 from cloudflare/jphillips/revert-PR-1033-main" This reverts commit 2182afd, reversing changes made to e4fe978. * Drive-by: Convert nullptr to kj::none There are also a few spots where we should have been comparing size or using default init on strings or arrays! * Drive-by: Convert actor cache uses of KJ_IF_MAYBE to KJ_IF_SOME * Add test for eviction of list with known gaps We weren't testing when we were evicting the last entry in a list with a known gap until an UNKNOWN (the end marker) entry. This matters because we had a hack in place to clean up the UNKNOWN entry which happens to have invalidated the cache list. This will be fixed in a following commit. * Bugfix: Don't double evict for UNKNOWN entries This was causing list iteration issues because UNKNOWN entries were now in the clean list. The fix here simply stops trying to clean up UNKNOWN entries after known empty gaps. They will be the oldest/stalest entries because if they were not then they would be dirty new entries. (We will not return a cached UNKNOWN result.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3a49006, reversing changes made to 812f78b.