Add missing types #1168
Merged
Add missing types #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elithrar
reviewed
Sep 12, 2023
types/defines/hyperdrive.d.ts
Outdated
| /* | ||
| * The randomly generated password to use when authenticating to your | ||
| * database via Hyperdrive. Like the host field, this password is only valid | ||
| * within the context of the currently running worker instance from which |
There was a problem hiding this comment.
Suggested change
| * within the context of the currently running worker instance from which | |
| * within the context of the currently running Worker instance from which |
types/defines/hyperdrive.d.ts
Outdated
|
|
||
| /* | ||
| * A randomly generated hostname that is only valid within the context of the | ||
| * currently running worker which, when passed into `connect()` function from |
There was a problem hiding this comment.
Suggested change
| * currently running worker which, when passed into `connect()` function from | |
| * currently running Worker which, when passed into `connect()` function from |
a-robinson
force-pushed
the
arobinson/hd-types
branch
from
829277e
to
2fe02dd
Compare
mrbbot
approved these changes
Sep 13, 2023
types/defines/hyperdrive.d.ts
Outdated
Comment on lines
1
to
4
| // Copyright (c) 2023 Cloudflare, Inc. | ||
| // Licensed under the Apache 2.0 license found in the LICENSE file or at: | ||
| // https://opensource.org/licenses/Apache-2.0 | ||
|
|
There was a problem hiding this comment.
The contents of files in the defines directory are concatenated as is to the types output. This means this copyright header will be interested mid-way through the file. I'd probably remove it. 👍
There was a problem hiding this comment.
Sure, I'll remove it. I just copied it from the other files, all but one of which have a similar header.
There was a problem hiding this comment.
Also opened up #1176 to remove the other headers in case that's something you think we ought to do.
a-robinson
force-pushed
the
arobinson/hd-types
branch
from
2fe02dd
to
7b24b2a
Compare
a-robinson
added a commit
that referenced
this pull request
Sep 13, 2023
As suggested by mrbbot on #1168
a-robinson
added a commit
that referenced
this pull request
Sep 13, 2023
As suggested by mrbbot on #1168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although FWIW I haven't really verified that what this generates looks ok, since I haven't been able to successfully
bazel build //types:typeson either my linux or mac boxes (even without this change).