Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nfc] Refactor bazel dependencies #1169

Merged
merged 1 commit into from
Sep 27, 2023
Merged

[nfc] Refactor bazel dependencies #1169

merged 1 commit into from
Sep 27, 2023

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented Sep 12, 2023

This allows us to avoid superfluous linker includes, for example the rust-deps library no longer need to be parsed for most api tests.

Full description to follow.

@fhanau fhanau force-pushed the felix/bazel-remodel branch 2 times, most recently from d4eba72 to bcf8909 Compare September 15, 2023 02:32
@fhanau fhanau changed the title [WIP][nfc] Refactor bazel dependencies [nfc] Refactor bazel dependencies Sep 24, 2023
@fhanau fhanau marked this pull request as ready for review September 24, 2023 19:20
Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though be sure to run our test suite for this in our internal repo before merging.

This allows us to avoid superfluous linker includes, for example the rust-deps library no longer need to be parsed for most api tests.
@fhanau fhanau merged commit 4ac08fe into main Sep 27, 2023
7 checks passed
@fhanau fhanau deleted the felix/bazel-remodel branch September 27, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants