Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment conversion in actor-cache.h. #1183

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix comment conversion in actor-cache.h. #1183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/workerd/io/actor-cache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,10 @@ class ActorCacheInterface: public ActorCacheOps {

virtual kj::Maybe<kj::Promise<void>> onNoPendingFlush() = 0;

virtual kj::Promise<kj::String> getCurrentBookmark();
virtual kj::Promise<kj::String> getBookmarkForTime(kj::Date timestamp);

// Implements the respective PITR API calls. The default implementations throw JSG errors saying
ohodson marked this conversation as resolved.
Show resolved Hide resolved
// PITR is not implemented.
ohodson marked this conversation as resolved.
Show resolved Hide resolved
virtual kj::Promise<kj::String> getCurrentBookmark();
virtual kj::Promise<kj::String> getBookmarkForTime(kj::Date timestamp);
ohodson marked this conversation as resolved.
Show resolved Hide resolved
virtual kj::Promise<kj::String> onNextSessionRestoreBookmark(kj::StringPtr bookmark);
ohodson marked this conversation as resolved.
Show resolved Hide resolved
};

Expand Down
Loading