Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS-46 Throw detailed errors properly #1219

Merged
merged 1 commit into from
Sep 21, 2023
Merged

VS-46 Throw detailed errors properly #1219

merged 1 commit into from
Sep 21, 2023

Conversation

ns476
Copy link
Contributor

@ns476 ns476 commented Sep 21, 2023

Previously the detailed error was always caught by the outer try/catch.

@github-actions
Copy link

github-actions bot commented Sep 21, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ns476
Copy link
Contributor Author

ns476 commented Sep 21, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Sep 21, 2023
@github-actions
@ns476 has signed the CLA from Pull Request #1219
2695e66
ndisidore
ndisidore approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@ndisidore ndisidore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching my oops!

@jasnell jasnell merged commit ad540fb into cloudflare:main Sep 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvinebroque irvinebroque irvinebroque approved these changes

@ndisidore ndisidore ndisidore approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ns476 @jasnell @ndisidore @irvinebroque