Fix various dropped promises #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the test wants to wait on the result of expectUncached(), and sometimes it doesn't. When it doesn't, cast the result to void to suppress warnings from discarding a promise. I did try waiting on some of these promises instead of dropping them, but that causes test failures. Seems like the dropping is intentional.
This looks like a simple missing "co_await". Earlier in the method, we have "co_await ws.receive()", so I think it's okay to "co_await ws.send(...)" as well.
Instead of awaiting sequentially, I opted to drain everything concurrently for lower latency.
There's no actual bug here. DigestStreamSink::write doesn't do any IO (it's a cryptographic digest; it just computes things), but it has to return kj::Promise<void> since it implements WritableStreamSink. This just silences a compiler warning.
| @@ -207,7 +207,7 @@ kj::Promise<void> HibernationManagerImpl::readLoop(HibernatableWebSocket& hib) { | |||
| // autoResponseTimestamp on the active websocket. | |||
| (active)->setAutoResponseTimestamp(hib.autoResponseTimestamp); | |||
| } | |||
| ws.send((reqResp)->getResponse().asArray()); | |||
| co_await ws.send((reqResp)->getResponse().asArray()); | |||
There was a problem hiding this comment.
@jqmmes what would you like to do here? Have it co_await or continue discarding until your fix is in?
There was a problem hiding this comment.
It's OK to merge it as is. I can update it later, once my PR is ready.
kentonv
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these by grabbing the changes from capnproto/capnproto#1810, which makes the compiler warn about dropped promises.