Accumulate reads in streams PumpToReader #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohodson
reviewed
Oct 2, 2023
ohodson
reviewed
Oct 2, 2023
ohodson
reviewed
Oct 2, 2023
ohodson
reviewed
Oct 2, 2023
ohodson
approved these changes
Oct 2, 2023
jasnell
force-pushed
the
jsnell/streams-pumploop-accumulate
branch
from
1945c7d
to
ea28d5f
Compare
harrishancock
approved these changes
Oct 3, 2023
When pumping from a JavaScript-backed stream to a WritableStreamSink, we want to ensure that small reads are accumulated into larger chunks to prevent a large number of small writes on the sink.
jasnell
force-pushed
the
jsnell/streams-pumploop-accumulate
branch
from
ea28d5f
to
85bfbc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pumping from a JavaScript-backed stream to a WritableStreamSink, we want to ensure that small reads are accumulated into larger chunks to prevent a large number of small writes on the sink.
Partially addresses: #1235