Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WritableStream will now wait for socket connection before closing. #1284

Merged
merged 1 commit into from
Oct 9, 2023
Merged

WritableStream will now wait for socket connection before closing. #1284

merged 1 commit into from
Oct 9, 2023

Conversation

dom96
Copy link
Collaborator

@dom96 dom96 commented Oct 6, 2023

No description provided.

@dom96 dom96 requested a review from jasnell October 6, 2023 22:53
@dom96 dom96 force-pushed the dominik/writable-wait-on-socket branch 2 times, most recently from 5d1720a to e373546 Compare October 9, 2023 10:54
@dom96 dom96 marked this pull request as ready for review October 9, 2023 10:55
jp4a50
jp4a50 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@jp4a50 jp4a50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the sake of expediency

src/workerd/api/sockets.c++ Show resolved Hide resolved
src/workerd/api/sockets.h Show resolved Hide resolved
@dom96 dom96 force-pushed the dominik/writable-wait-on-socket branch from e373546 to aef20a0 Compare October 9, 2023 15:13
@dom96 dom96 force-pushed the dominik/writable-wait-on-socket branch from aef20a0 to 27f699b Compare October 9, 2023 17:22
@dom96 dom96 merged commit 15d6812 into main Oct 9, 2023
7 checks passed
@dom96 dom96 deleted the dominik/writable-wait-on-socket branch October 30, 2023 15:17
@dom96 dom96 mentioned this pull request Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell left review comments

@jp4a50 jp4a50 jp4a50 approved these changes

@harrishancock harrishancock Awaiting requested review from harrishancock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dom96 @jasnell @jp4a50