Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Reduce Windows debug binary size #1619

Merged
merged 1 commit into from
Feb 22, 2024
Merged

[CI] Reduce Windows debug binary size #1619

merged 1 commit into from
Feb 22, 2024

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented Feb 5, 2024

This resolves CI failures due to running out of disk space, at least for
the near term. Also drops a flag modifying features for windows_no_dbg,
disabling optimizations when building for the host configuration is not
necessary.

I picked common MSVC flags that are safe to use with debug info here. When I last measured this, the bazel output + cache takes up 60GB with this on a fully cached Windows-debug build whereas the build previously ran out of space upon reaching 70GB. Based on those numbers this is just a short-term fix unfortunately, a larger improvement would be possible by changing cache behavior (70GB is only reached when binaries are duplicated between disk cache and regular bazel output) or by patching bazel to make opting out of PDB generation possible.

@fhanau fhanau force-pushed the felix/ci-disk-size-v2 branch 2 times, most recently from ab447ee to 35fc98c Compare February 7, 2024 18:04
This resolves CI failures due to running out of disk space, at least for
the near term. Also drops a flag modifying features for windows_no_dbg,
disabling optimizations when building for the host configuration is not
necessary.
@fhanau fhanau changed the title [WIP][CI] Reduce Windows binary size [CI] Reduce Windows binary size Feb 22, 2024
@fhanau fhanau requested a review from mikea February 22, 2024 01:48
@fhanau fhanau changed the title [CI] Reduce Windows binary size [CI] Reduce Windows debug binary size Feb 22, 2024
@fhanau fhanau marked this pull request as ready for review February 22, 2024 01:54
@fhanau fhanau requested review from a team as code owners February 22, 2024 01:54
@fhanau
Copy link
Collaborator Author

fhanau commented Feb 22, 2024

When a PR to reduce disk space usage has failing CI jobs due to still having too much disk space 😭😭😭
I think the recent additions of WebGPU and Python support with its large capnp embeds really did a number on the Windows runner since it is already encumbered with so much debug info and it is duplicated in a PDB file. I will merge this as the build fails later in the process than on main which is consistent with the 70GB => 60GB disk space reduction encountered when I first made this PR, but this is insufficient to resolve the problem unfortunately.

@fhanau fhanau merged commit ae47406 into main Feb 22, 2024
10 of 11 checks passed
@fhanau fhanau deleted the felix/ci-disk-size-v2 branch February 22, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants