Revert "Fixup gc tracing in EventTarget" #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, maybe the right thing to do is to visit the handle only via the reference, since that's the only path by which the JS handles are actually accessed. |
jasnell
approved these changes
Feb 9, 2024
kentonv
force-pushed
the
revert-1648-jsnell/fixup-gctrace-basics
branch
from
493c3a2
to
1d8ede4
Compare
|
Extended this with a better fix. |
jasnell
approved these changes
Feb 9, 2024
See comments for details. I've changed `newNativeHandler()` to return `Own<void>` to make it really clear that the owner is not supposed to access the object.
This ensures that users call `newNativeHandler()` rather than constructing it directly.
kentonv
force-pushed
the
revert-1648-jsnell/fixup-gctrace-basics
branch
from
1d8ede4
to
b953f47
Compare
jasnell
approved these changes
Feb 9, 2024
This was made strong in a recent refactoring, but it doesn't need to be. EventTarget can remove the reference in the destructor.
kentonv
force-pushed
the
revert-1648-jsnell/fixup-gctrace-basics
branch
from
dfebcd3
to
96f5670
Compare
|
Whoops, a little fix caught by ASAN: https://github.com/cloudflare/workerd/compare/dfebcd3433f9dfd88caed1ef88504562d9fa30ca..96f5670a93e0329e6346b60ffdd6bd9334fab899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1648
This change was not correct, see analysis here:
#1648 (comment)