Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SQLite VTable module name comparison case-insensitive #1762

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Make SQLite VTable module name comparison case-insensitive #1762

merged 3 commits into from
Mar 13, 2024

Conversation

KianNH
Copy link
Contributor

@KianNH KianNH commented Mar 4, 2024

Fixes #1760

@KianNH KianNH requested review from a team as code owners March 4, 2024 12:31
rozenmd
rozenmd reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@rozenmd rozenmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know C++ but seems legit to me

kentonv
kentonv reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@kentonv kentonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a test added to sql-test.js? Maybe just change the one line that references fts5 to be FtS5 instead?

src/workerd/util/sqlite.c++ Outdated Show resolved Hide resolved
@KianNH
Copy link
Contributor Author

KianNH commented Mar 4, 2024 •
edited
Loading

Windows tests are failing due to a 500 from the remote cache from the looks of it, but I suspect it's since we're only adding a define for strncasecmp -> _strnicmp and not strcasecmp -> _stricmp (I don't see anything in the logs to indicate that, but I'm not sure what else it could be about this change that it doesn't like).

kentonv
kentonv approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@kentonv kentonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why Mac build failed, I'm re-running it.

Whoever merges this: Don't forget to choose squash-merge.

@rozenmd rozenmd merged commit e121866 into cloudflare:main Mar 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozenmd rozenmd rozenmd left review comments

@kentonv kentonv kentonv approved these changes

@fhanau fhanau Awaiting requested review from fhanau fhanau is a code owner automatically assigned from cloudflare/workers-runtime-1

@Frederik-Baetens Frederik-Baetens Awaiting requested review from Frederik-Baetens Frederik-Baetens is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report — Runtime APIs - FTS5 authorization needed
3 participants
@KianNH @rozenmd @kentonv