Remove Fetcher methods get(), put(), delete() with compat flag. #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were intended to be convenient wrappers around `fetch()` that perform the respective HTTP method. It was a bad idea (my fault). Luckily it was never documented and probably few people depend on it. Note that a long time ago, KV namespace bindings were Fetchers rather than being the specific KvNamespace type. This had lots of problems, but sort of worked as long as your key names were URL-safe. It's possible very old scripts are in production that still depend on these old-style bindings, but they won't be broken since they obviously have ancient compat dates as well. (In fact... they predate compat dates...)
jasnell
reviewed
Mar 5, 2024
| @@ -12,13 +12,21 @@ export class DurableObjectExample { | |||
| foo() { | |||
| return 123; | |||
| } | |||
|
|
|||
| fetch(req) { | |||
| return new Response(req.method + " " + req.url); | |||
There was a problem hiding this comment.
Suggested change
| return new Response(req.method + " " + req.url); | |
| return new Response(`${req.method} ${req.url}`); |
There was a problem hiding this comment.
Agreed that's an improvement. Don't think it's worth restarting CI, though.
jasnell
approved these changes
Mar 5, 2024
|
This is actually a pretty cool idea and TIL it existed! Very similar to Pages Functions. |
kentonv
added a commit
to cloudflare/cloudflare-docs
that referenced
this pull request
Mar 5, 2024
As implemented in: cloudflare/workerd#1770
|
The "linux" build seems to have hung on mksnapshot, but "linux-debug" passed and all internal builds passed, and GitHub apparently cannot cancel the hung workflow, it's just gonna run until it times out or something. I'm just going to merge. |
kentonv
added a commit
to cloudflare/cloudflare-docs
that referenced
this pull request
Mar 6, 2024
* Document compat flag: fetcher_no_get_put_delete As implemented in: cloudflare/workerd#1770 * Update content/workers/_partials/_platform-compatibility-dates/fetcher-no-get-put-delete.md * Apply suggestions from code review Co-authored-by: Brendan Irvine-Broque <[email protected]> --------- Co-authored-by: Brendan Irvine-Broque <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were intended to be convenient wrappers around
fetch()that perform the respective HTTP method. It was a bad idea (my fault). Luckily it was never documented and probably few people depend on it.Note that a long time ago, KV namespace bindings were Fetchers rather than being the specific KvNamespace type. This had lots of problems, but sort of worked as long as your key names were URL-safe. It's possible very old scripts are in production that still depend on these old-style bindings, but they won't be broken since they obviously have ancient compat dates as well. (In fact... they predate compat dates...)