Increase the timeout for storage operations before resetting an actor #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-robinson
requested review from
mikea,
dom96,
jclee and
Frederik-Baetens
and removed request for
dom96
MellowYarker
approved these changes
Mar 11, 2024
jasnell
approved these changes
Mar 11, 2024
The lower timeout could plausibly be hit purely due to a busy CPU loop after issuing a storage operation. The new number matches the CPU limit per request. There's no need for this to be exactly the same number as that, but it seemed just as good a reason as I had for any other larger number.
a-robinson
force-pushed
the
arobinson/slow-storage-op-timeout
branch
from
9e68d77
to
3fbf7c8
Compare
|
Rebased on latest main in order to ease merging into the internal repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lower timeout could plausibly be hit purely due to a busy CPU loop after issuing a storage operation. The new number matches the CPU limit per request. There's no need for this to be exactly the same number as that, but it seemed just as good a reason as I had for any other larger number.