Fix recently-introduced onAbort() in WorkerEntrypoint::customEvent(). #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
force-pushed
the
kenton/fix-onabort
branch
from
73f883b
to
b9d5a9f
Compare
ObsidianMinor
approved these changes
Mar 12, 2024
The `IoContext` will be destroyed during the course of `event->run()`, at which point this `onAbort()` will reject with a "PromiseFulfiller destroyed without fulfilling promise" exception. I don't know why this doesn't happen in tests but it seems to happen a lot in prod? Anyway, I moved the `onAbort()` handling into the JSRPC CustomEvent implementation, which is the place I needed it for my purposes. I suspect many CustomEvent implementations do not honor onAbort(), though, which will need to be fixed later.
kentonv
force-pushed
the
kenton/fix-onabort
branch
from
b9d5a9f
to
998871c
Compare
jasnell
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IoContextwill be destroyed during the course ofevent->run(), at which point thisonAbort()will reject with a "PromiseFulfiller destroyed without fulfilling promise" exception. I don't know why this doesn't happen in tests but it seems to happen a lot in prod?Anyway, I moved the
onAbort()handling into the JSRPC CustomEvent implementation, which is the place I needed it for my purposes. I suspect many CustomEvent implementations do not honor onAbort(), though, which will need to be fixed later.