Separate out some jsg::Url mods from the module registry refactor #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! One small question: Is it valid to percent-encode a byte with mixed-case? like %bA |
garrettgu10
approved these changes
Mar 13, 2024
|
Yes, the percent encoding is case-insensitive. Generally, as a best practice, you're always supposed to produce upper-case sequences but accept any mix of cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates the
jsg::Urlmodifications out from the module registry refactor PR to ever-so-slightly reduce the size of that PR... addresses review comments also.Refs: #1553