Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass scriptId in Trace #1858

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Pass scriptId in Trace #1858

merged 1 commit into from
Apr 15, 2024

Conversation

zebp
Copy link
Contributor

@zebp zebp commented Mar 18, 2024

Passes scriptId and sourcemapsAvailable through various usages of Trace.

@zebp zebp requested review from a team as code owners March 18, 2024 19:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

mikea
mikea reviewed Mar 19, 2024
View reviewed changes
src/workerd/io/trace.c++ Outdated Show resolved Hide resolved
@zebp zebp force-pushed the zeb/script-id-sourcemaps branch from cb44afe to aec3e02 Compare April 4, 2024 16:11
@jclee
Copy link
Contributor

jclee commented Apr 4, 2024

I'm not sure exactly how the new field is intended to be consumed, but it might be worth noting that scriptId is an internal ID, which isn't intended to be exposed to users.

@zebp
Copy link
Contributor Author

zebp commented Apr 5, 2024

I'm not sure exactly how the new field is intended to be consumed, but it might be worth noting that scriptId is an internal ID, which isn't intended to be exposed to users.

The new field is consumed by a the sourcemap stacktrace remapping system within the internal runtime and is not exposed to users at any point

@zebp zebp changed the title Pass scriptId and sourcemapsAvailable in Trace Pass scriptId in Trace Apr 5, 2024
@zebp zebp force-pushed the zeb/script-id-sourcemaps branch 4 times, most recently from 250b51c to 09fca7f Compare April 12, 2024 14:05
@mikea mikea merged commit 2085fbd into cloudflare:main Apr 15, 2024
10 checks passed
garrettgu10 pushed a commit that referenced this pull request Apr 17, 2024
@zebp @garrettgu10
Pass scriptId in Trace (#1858)
a984074
garrettgu10 pushed a commit that referenced this pull request May 13, 2024
@zebp @garrettgu10
Pass scriptId in Trace (#1858)
fd9e021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikea mikea mikea left review comments

@jasnell jasnell jasnell approved these changes

@dom96 dom96 Awaiting requested review from dom96 dom96 is a code owner automatically assigned from cloudflare/workers-runtime-1

@ObsidianMinor ObsidianMinor Awaiting requested review from ObsidianMinor ObsidianMinor is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zebp @jclee @mikea @jasnell