Python: Reduce memory usage when restoring snapshot #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
hoodmane/reduce-snapshot-memory-usage
branch
from
7c6c2ca
to
35d5ea1
Compare
dom96
reviewed
Mar 21, 2024
hoodmane
force-pushed
the
hoodmane/reduce-snapshot-memory-usage
branch
from
35d5ea1
to
6787e25
Compare
dom96
approved these changes
Mar 22, 2024
hoodmane
force-pushed
the
hoodmane/reduce-snapshot-memory-usage
branch
3 times, most recently
from
8d2fe64
to
84687f2
Compare
Previously we paid for two copies of the snapshot memory: one copy in the wasm linear memory itself and a second copy in `BUNDLE_MEMORY_SNAPSHOT`. This ensures that we never have more memory than one copy of the linear memory heap by copying the memory directly from the snapshot to the linear memory. We also release the C++ memory when we are done with it.
hoodmane
force-pushed
the
hoodmane/reduce-snapshot-memory-usage
branch
from
84687f2
to
34da5ba
Compare
dom96
reviewed
Mar 27, 2024
Co-authored-by: Dominik Picheta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we paid for two copies of the snapshot memory: one copy in the wasm linear memory itself and a second copy in
BUNDLE_MEMORY_SNAPSHOT. This ensures that we never have more memory than one copy of the linear memory heap by copying the memory directly from the snapshot to the linear memory. We also release the C++ memory when we are done with it.