Python memory snapshot: add magic number and version #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
commented
Mar 25, 2024
hoodmane
force-pushed
the
hoodmane/snapshot-magic-version
branch
from
da5b4ce
to
05181c5
Compare
dom96
approved these changes
Mar 26, 2024
hoodmane
force-pushed
the
hoodmane/snapshot-magic-version
branch
8 times, most recently
from
dd18e00
to
5d47af1
Compare
dom96
approved these changes
Mar 27, 2024
| @@ -186,9 +186,13 @@ function loadDynlib(Module, path, wasmModuleData) { | |||
| * there. | |||
| */ | |||
| function preloadDynamicLibs(Module) { | |||
| let SO_FILES_TO_LOAD = SITE_PACKAGES_SO_FILES; | |||
| if (DSO_METADATA?.settings?.baselineSnapshot) { | |||
| SO_FILES_TO_LOAD = [[ '_lzma.so' ]]; | |||
There was a problem hiding this comment.
is this definitely safe? Should we maybe not preload anything just to be extra cautious?
There was a problem hiding this comment.
This gets imported by something in SNAPSHOT_IMPORTS I'm not really sure why. But because we use it in the snapshot, we'll crash without it.
hoodmane
force-pushed
the
hoodmane/snapshot-magic-version
branch
2 times, most recently
from
0e7cb97
to
bbde92e
Compare
hoodmane
force-pushed
the
hoodmane/snapshot-magic-version
branch
from
bbde92e
to
81b39d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.