Quick ActorCache refactor #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-robinson
approved these changes
Mar 28, 2024
MellowYarker
force-pushed
the
milan/actor-cache-refactor
branch
from
5fa38e9
to
d7857a7
Compare
justin-mp
requested changes
Mar 29, 2024
MellowYarker
force-pushed
the
milan/actor-cache-refactor
branch
from
fcef6f6
to
cb4562c
Compare
Reading actor cache isn't easy, and if things are immutable then we should convey that in the code.
This allows us to mutate from UNKNOWN to PRESENT or ABSENT but permit no other transition.
This commit introduces `addToCleanList()` and `addToDirtyList()` to make it obvious when we're actually transitioning between lists.
MellowYarker
force-pushed
the
milan/actor-cache-refactor
branch
from
f8b58b5
to
d680fba
Compare
This helps make it a bit more obvious that we don't want to touch `syncStatus` directly.
MellowYarker
force-pushed
the
milan/actor-cache-refactor
branch
from
d680fba
to
3b5e7a0
Compare
a-robinson
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Still LGTM, but it looks like merge on this will be blocked until @justin-mp removes his "Request changes" bit.
justin-mp
approved these changes
Apr 15, 2024
jasnell
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits were scattered before and after the larger read coalesce changes, and since that change is really big and complicated, I figured it would be easier to yank these quick refactors out into a separate PR so we can focus on the scary stuff elsewhere.