Fix universal snapshots again #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
hoodmane/fix-univ-snap-again
branch
from
27bf3b1
to
37e3809
Compare
hoodmane
force-pushed
the
hoodmane/fix-univ-snap-again
branch
from
1d777f8
to
5149c00
Compare
dom96
approved these changes
Mar 29, 2024
| @@ -397,6 +420,9 @@ function memorySnapshotDoImports(Module) { | |||
| function makeLinearMemorySnapshot(Module) { | |||
| memorySnapshotDoImports(Module); | |||
| const dsoJSON = recordDsoHandles(Module); | |||
| if (IS_CREATING_BASELINE_SNAPSHOT) { | |||
| // checkLoadedSoFiles(dsoJSON); | |||
There was a problem hiding this comment.
Should this be commented out?
There was a problem hiding this comment.
It doesn't work with the intentionally messed up creation logic in preloadDynamicLibs so we can leave a todo to enable a check like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.