-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Make top level random() raise #1952
Conversation
a458ad2
to
511e04f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions to make the code easier to understand, otherwise LGTM.
65f768a
to
89f6af5
Compare
Okay I updated this to handle numpy, added more detailed comments and internal tests. |
fef5054
to
0f06a50
Compare
Okay, now there is a problem that rust uses randomness for hash seeds: |
698262d
to
2fe472c
Compare
We don't have access to entropy outside of request scope, so `random()` will give poor results. Raise an error if it is called.
2fe472c
to
aa190bf
Compare
We don't have access to entropy outside of request scope, so `random()` will give poor results. Raise an error if it is called.
We don't have access to entropy outside of request scope, so
random()
will give poor results. Raise an error if it is called.