Add runInV8Stack to JobTaskWrapper::Run #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettgu10
force-pushed
the
ggu/add-stackstartmarker
branch
from
6ae6ec0
to
9301b5f
Compare
garrettgu10
changed the title
garrettgu10
force-pushed
the
ggu/add-stackstartmarker
branch
from
9301b5f
to
116d480
Compare
jasnell
approved these changes
Apr 9, 2024
vickykont
pushed a commit
that referenced
this pull request
Apr 15, 2024
garrettgu10
added a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating to v8 12.4, a few tests failed because the manual stack start wasn't being set in some compilation threads, and I think this is probably the right place to set it since it showed up near the top of the thread's stacktrace when I added an invariant in v8 that (!use_manual_stack_start || manual_stack_start != nullptr).