Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package installation in workerd with top level entropy restrictions #2091

Merged
merged 1 commit into from
May 6, 2024

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented May 6, 2024

Package installation uses tempfile which tries to create entropy. This patches it to use a deterministic sequence of file names.

@garrettgu10

Package installation uses tempfile which tries to create entropy. This patches
it to use a deterministic sequence of file names.
@hoodmane hoodmane requested review from a team as code owners May 6, 2024 13:32
Copy link
Collaborator

@garrettgu10 garrettgu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, LGTM 🚀

@hoodmane hoodmane merged commit 7bca90d into main May 6, 2024
10 checks passed
@hoodmane hoodmane deleted the entropy-tempfile branch May 6, 2024 15:40
garrettgu10 pushed a commit that referenced this pull request May 13, 2024
…ns (#2091)

Package installation uses tempfile which tries to create entropy. This patches
it to use a deterministic sequence of file names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants